refactor(content): simplify MonetizationLinkManager #538

sidvishnoi · 2024-08-23T12:05:44Z

Context

Closes #455

Changes proposed in this pull request

Rename MonetizationTagManager to MonetizationLinkManager (as we want to handle only links in this service)
Simplify and reorganize MonetizationLinkManager
TypeScript improvements (check more things)

Co-authored-by: Radu-Cristian Popa <[email protected]>

github-actions · 2024-08-23T12:06:39Z

Extension builds preview

Name	Link
Latest commit	`34e46d0`
Latest job logs	Run #10900254652
	Download
	Download

Co-authored-by: Radu-Cristian Popa <[email protected]>

Relatively safe to do as we don't update it often. Would require page reload otherwise - which can lead to data loss. "undefining" properties is also not an option - as otherwise any script on page on reconfigure them.

Prevents Extension context invalidated error (at least I don't see it in console anymore)

raducristianpopa

Only code review for now - will have to test the extension as well.

src/content/services/monetizationLinkManager.ts

src/content/services/frameManager.ts

src/content/polyfill.ts

as static checkHrefFormat

raducristianpopa

It looks like the Monetization event is not sent to links inside iframes nor we send the START_MONETIZATION message to background from an iframe?

load event is sent on the other hand - the link is being validated.

raducristianpopa

Before merging this, let's get some feedback from other persons as well to check if this is working as expected.

raducristianpopa

test-e2e

sidvishnoi and others added 4 commits August 23, 2024 16:37

add MonetizationLinkManager: basics of link available on page load

a42ffce

Co-authored-by: Radu-Cristian Popa <[email protected]>

stop/resume on visibilitychange

659c831

nit: rename param

fcee306

watch for add/remove of link tags

810cb7b

github-actions bot added the area: content Improvements or additions to extension content script label Aug 23, 2024

sidvishnoi and others added 6 commits August 23, 2024 18:09

handle onmonetization attribute change

dd9f59b

Co-authored-by: Radu-Cristian Popa <[email protected]>

handle element attribute changes; move things around

ee0fad9

Co-authored-by: Radu-Cristian Popa <[email protected]>

onAddedNode/onAddedLink; nits

0b5707f

stop first on href change

1fec4d8

Merge branch 'main' into refactor-tag-manager

04154a8

handle toggleWM within background only

2056b5f

github-actions bot added the area: background Improvements or additions to extension background script label Aug 26, 2024

sidvishnoi added 11 commits August 26, 2024 18:06

remove todo notes/comments

2df5eb6

remove unused types

038cfed

bring in iframe support with existing frameMananger

bfa8d64

remove monetizationTagManager; use monetizationLinkManager

c53b7e1

update payload types (extract *PayloadEntry out)

b192f05

nit: extract postMessage call to private method

5885b5f

add types for Window.postMessage messages

1a9920e

nit

d1e837f

implement MonetizationLinkManager.end (unlisten everything)

0bea75c

don't define polyfill again on re-inject

8bf32a2

Relatively safe to do as we don't update it often. Would require page reload otherwise - which can lead to data loss. "undefining" properties is also not an option - as otherwise any script on page on reconfigure them.

cleanup MonetizationLinkManager on disconnect

76f2e92

Prevents Extension context invalidated error (at least I don't see it in console anymore)

sidvishnoi requested a review from raducristianpopa August 28, 2024 12:10

raducristianpopa reviewed Sep 2, 2024

View reviewed changes

sidvishnoi added 4 commits September 6, 2024 16:07

Merge branch 'main' into refactor-tag-manager

525d35b

rename CHECK_WALLET_ADDRESS_URL to GET_WALLET_ADDRESS_INFO

32662ae

move checkWalletAddressUrlFormat into monetizationLinkManager

729e14f

as static checkHrefFormat

move isNotNull to shared/helpers

5e47bfc

sidvishnoi added 3 commits September 6, 2024 16:24

move isDocumentReady in

1b84570

don't use statics, keep helpers separately testable

d061527

move context-invalidation bug related code out of this PR

ce72dfb

sidvishnoi marked this pull request as ready for review September 6, 2024 11:06

sidvishnoi requested a review from raducristianpopa September 6, 2024 11:06

sidvishnoi added 7 commits September 9, 2024 15:29

Merge branch 'main' into refactor-tag-manager

0155835

nit: simplify toggleWM logic

d351645

move getMonetizationLinkTags into MonetizationLinkManager

52e5f87

frameManager: move HANDLED_MESSAGES to top-level constant

0aec471

style: import order

92d3122

remove unused types

c7babdb

move checkHrefFormat into class also

c9ab817

raducristianpopa reviewed Sep 10, 2024

View reviewed changes

sidvishnoi added 3 commits September 10, 2024 20:12

Merge branch 'main' into refactor-tag-manager

15937b1

fix iframe integration (tried method reuse too much)

3cad011

add resume payload length check

f2543d9

sidvishnoi requested a review from raducristianpopa September 11, 2024 07:00

sidvishnoi added 2 commits September 11, 2024 12:31

Merge branch 'main' into refactor-tag-manager

34157be

Merge branch 'main' into refactor-tag-manager

5e735ed

raducristianpopa approved these changes Sep 12, 2024

View reviewed changes

sidvishnoi added 2 commits September 13, 2024 17:41

Merge branch 'main' into refactor-tag-manager

7ba33cc

Merge branch 'main' into refactor-tag-manager

4d61c2d

raducristianpopa reviewed Sep 16, 2024

View reviewed changes

raducristianpopa temporarily deployed to test September 16, 2024 13:36 — with GitHub Actions Inactive

raducristianpopa had a problem deploying to test September 16, 2024 13:36 — with GitHub Actions Failure

raducristianpopa temporarily deployed to test September 16, 2024 13:41 — with GitHub Actions Inactive

sidvishnoi added 2 commits September 16, 2024 21:04

Merge branch 'main' into refactor-tag-manager

cdaafed

Merge branch 'main' into refactor-tag-manager

34e46d0

sidvishnoi merged commit 5df489f into main Sep 17, 2024
8 checks passed

sidvishnoi deleted the refactor-tag-manager branch September 17, 2024 13:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(content): simplify MonetizationLinkManager #538

refactor(content): simplify MonetizationLinkManager #538

sidvishnoi commented Aug 23, 2024 •

edited

Loading

github-actions bot commented Aug 23, 2024 •

edited

Loading

raducristianpopa left a comment

raducristianpopa left a comment

raducristianpopa left a comment

raducristianpopa left a comment

refactor(content): simplify MonetizationLinkManager #538

refactor(content): simplify MonetizationLinkManager #538

Conversation

sidvishnoi commented Aug 23, 2024 • edited Loading

Context

Changes proposed in this pull request

github-actions bot commented Aug 23, 2024 • edited Loading

Extension builds preview

raducristianpopa left a comment

Choose a reason for hiding this comment

raducristianpopa left a comment

Choose a reason for hiding this comment

raducristianpopa left a comment

Choose a reason for hiding this comment

raducristianpopa left a comment

Choose a reason for hiding this comment

sidvishnoi commented Aug 23, 2024 •

edited

Loading

github-actions bot commented Aug 23, 2024 •

edited

Loading